[pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

[Tanu Kaskinen]

On Tue, 2012-11-20 at 17:59 +0000, Ian Malone wrote:
> On 20 November 2012 17:37, Tanu Kaskinen <tanuk at iki.fi> wrote:
> > On Tue, 2012-11-20 at 12:45 +0200, Tanu Kaskinen wrote:
> >> On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote:
> >> > I'm seeing this in virtual box under KDE (also Fedora 18 / pulseaudio 2.1).
> >> >
> >> > On my real desktop, if I configure qjackctl to autostart on logon and in
> >> > turn autostart jack I do not see the problem.
> >> >
> >> > If I stop jack and resume normal desktop use and restart jack after a
> >> > time, the issue does occur.
> >> >
> >> > pulseaudio --kill; pulseaudio --start always fixes the issue.
> >> >
> >> > Is there something I can look out for in the logs, or something I can
> >> > try via pacmd while it is happening to aid in debugging this issue?
> >> >
> >> > We are very close to the release date of the Fedora Audio spin and
> >> > really want to have jack and pulse coexist directly from the install
> >> > media but this issue is holding us back.
> >> >
> >> > Let me know if there is anyway I can help
> >>
> >> I can reproduce some weird behavior which I've been investigating, but
> >> right now there's a bluetooth bug that is at a higher priority. I think
> >> I can finish that today, though, so I can continue with this device
> >> reservation stuff right after that.
> >>
> >> I don't think I need more debug information right now - let's see if
> >> fixing the bugs that I'm seeing also fixes your issues.
> >
> > I've attached a patch that fixes the bug that I've been investigating.
> > The fix ended up being very simple, but I think it's quite unlikely that
> > it will fix your problem. If you could try the patch, that would be
> > great. In the mean time, I'll try to reproduce the bug that you're
> > seeing.
> >
> 
> Thanks, I'll give it a go. I think handling the already_owner case in
> reserve.c as well might be worthwhile since there may be other ways to
> get to that state.

I think it's a bug in the application if it calls rd_acquire for a
device that it already owns. An assertion might be the way to go. If not
an assertion, then at least an error.

-- 
Tanu