[pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

Tanu Kaskinen tanuk at iki.fi
Tue Nov 20 11:01:43 PST 2012


On Tue, 2012-11-20 at 20:43 +0200, Tanu Kaskinen wrote:
> On Tue, 2012-11-20 at 17:59 +0000, Ian Malone wrote:
> > Thanks, I'll give it a go. I think handling the already_owner case in
> > reserve.c as well might be worthwhile since there may be other ways to
> > get to that state.
> 
> I think it's a bug in the application if it calls rd_acquire for a
> device that it already owns. An assertion might be the way to go. If not
> an assertion, then at least an error.

When writing that, I didn't realize that the current code already
returns an error if dbus_bus_request_name() returns
DBUS_REQUEST_NAME_REPLY_ALREADY_OWNER. I think that's a fine way of
handling it, so in my opinion nothing needs to be done here.

-- 
Tanu



More information about the pulseaudio-discuss mailing list