[pulseaudio-discuss] [PATCH 29/56] bluetooth: Implement org.bluez.MediaEndpoint1.SetConfiguration()

[João Paulo Rechi Vita]

On Aug 2, 2013 5:02 AM, "Tanu Kaskinen" <tanu.kaskinen at linux.intel.com>
wrote:
>
> On Fri, 2013-08-02 at 08:44 +0200, Thomas Martitz wrote:
> > Am 02.08.2013 02:10, schrieb João Paulo Rechi Vita:
> > > On Fri, Jul 19, 2013 at 7:24 AM, Tanu Kaskinen
> > > <tanu.kaskinen at linux.intel.com> wrote:
> > >> (Sorry, I sent the previous mail too early. I hadn't yet finished
> > >> reviewing this patch.)
> > >>
> > >> On Fri, 2013-07-12 at 15:06 -0300, jprvita at gmail.com wrote:
> > >>> +
> > >>> +        if (strcasecmp(key, "UUID") == 0) {
> > >> What is the reason to use strcasecmp() instead of pa_streq()?
> > >>
> > > This was copied from previous code, I'm changing it to pa_streq.
> >
> >
> > Not sure if it matters here but pa_streq() doesn't ignore the case in
> > contrast to strcasecmp(). So it's not completely equivalent.
>
> Yes, I asked what the reason is because there could be some reason, but
> there probably isn't. The only possible reason that I can see would be
> that BlueZ wants to reserve the right to change the case of the
> properties at will. I really hope they don't want to do that.
>

Sorry I haven't been clear enough: there is no need to ignore case here, so
it makes sense to use pa_streq(). The reason strcasecmp() was used in the
first patch is that this piece of code was moved from somewhere else, and
strcasecmp() was used there originally.

--
João Paulo Rechi Vita
http://about.me/jprvita
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20130802/b431dd60/attachment.html>