[pulseaudio-discuss] [PATCHv2 18/60] bluetooth: Prefix BlueZ 4 card profiles enum with PA_BLUEZ4_

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Thu Aug 15 08:37:00 PDT 2013


On Tue, 2013-08-13 at 01:53 -0300, jprvita at gmail.com wrote:
> From: João Paulo Rechi Vita <jprvita at openbossa.org>
> 
> ---
>  src/modules/bluetooth/bluez4-util.c          |  44 ++++-----
>  src/modules/bluetooth/bluez4-util.h          |  18 ++--
>  src/modules/bluetooth/module-bluez4-device.c | 134 +++++++++++++--------------
>  3 files changed, 98 insertions(+), 98 deletions(-)

> diff --git a/src/modules/bluetooth/bluez4-util.h b/src/modules/bluetooth/bluez4-util.h
> index b920545..87c9c11 100644
> --- a/src/modules/bluetooth/bluez4-util.h
> +++ b/src/modules/bluetooth/bluez4-util.h
> @@ -57,15 +57,15 @@ struct pa_bluez4_uuid {
>      PA_LLIST_FIELDS(pa_bluez4_uuid);
>  };
>  
> -enum profile {
> -    PROFILE_A2DP,
> -    PROFILE_A2DP_SOURCE,
> -    PROFILE_HSP,
> -    PROFILE_HFGW,
> -    PROFILE_OFF
> +enum pa_bluez4_profile {
> +    PA_BLUEZ4_PROFILE_A2DP,
> +    PA_BLUEZ4_PROFILE_A2DP_SOURCE,
> +    PA_BLUEZ4_PROFILE_HSP,
> +    PA_BLUEZ4_PROFILE_HFGW,
> +    PA_BLUEZ4_PROFILE_OFF
>  };

Great, I have wanted to do this for a long time, but I have never done
it, because it's a bit intrusive change. One complaint: the enumeration
should be typedeffed as pa_bluez4_profile_t.

-- 
Tanu



More information about the pulseaudio-discuss mailing list