[pulseaudio-discuss] [PATCH pavucontrol] ellipsize labels to fix window resizing

[Tanu Kaskinen]

On Fri, 2013-12-13 at 17:53 +0600, Alexander E. Patrakov wrote:
> 2013/12/13 Tanu Kaskinen <tanu.kaskinen at linux.intel.com>:
> 
> > How did you apply the patch? By hand? It doesn't apply on my fresh
> > checkout of the pavucontrol master branch.
> 
> I have saved the e-mail from gmail web interface. Indeed, due to
> trailing CRs, it doesn't apply with "git am", but does apply with
> "patch -Np1 -i pavucontrol.diff". I attached the resulting
> git-formatted patch for your convenience.
> 
> 
> >> Result: the stream title ellipsized to just "...", and the combo box
> >> that allows to select the device becomes wider than the window. I'd
> >> argue that it either should be initially as wide as its widest item
> >> (i.e. the widest sink name in this case), or that the sink names
> >> should also be ellipsized.
> >
> > Can you file a bug about this? The patch probably does more good than
> > harm (do you agree?), and since it's not clear how to fix the remaining
> > issue, I think it's best to apply the patch (as soon as someone posts a
> > patch that can actually be applied cleanly).
> 
> I'd say that the patch does no harm at all, and the ugly thing that I
> found can be fixed later. As for the bug, we can reuse
> https://bugs.freedesktop.org/show_bug.cgi?id=70964 , as that's what
> the original patch was about. I will add a comment there.

Great, thanks! I applied the patch now.

-- 
Tanu