[pulseaudio-discuss] [PATCH 0/2] modules, pulse, core: React to failing pa_memblockq_push calls.

[Tanu Kaskinen]

On Thu, 2012-05-24 at 10:38 +0300, Jarkko Suontausta wrote:
> Based on Coverity findings, the return values of pa_memblockq_push and
> pa_memblockq_push_align calls were not taken into account. These patches
> are addressing many of those cases by adding an assertion.
> 
> Thanks to a thorough review of the first version, Tanu is already familiar
> with the patches. He had many good proposals for the remaining FIXME cases,
> but unfortunately I do not have time to address them now.
> 
> 
> Jarkko Suontausta (2):
>   core: Assert on memchunk divisibility by sample spec in
>     pa_memblockq_push().
>   modules, pulse, core: React to failing pa_memblockq_push calls.
> 
>  src/modules/echo-cancel/module-echo-cancel.c |    4 ++--
>  src/modules/module-combine-sink.c            |    2 ++
>  src/modules/module-equalizer-sink.c          |    4 ++--
>  src/modules/module-ladspa-sink.c             |    2 +-
>  src/modules/module-loopback.c                |    1 +
>  src/modules/module-virtual-sink.c            |    2 +-
>  src/modules/module-virtual-source.c          |    2 +-
>  src/modules/module-virtual-surround-sink.c   |    2 +-
>  src/pulse/context.c                          |    1 +
>  src/pulsecore/memblockq.c                    |    3 +--
>  src/pulsecore/memblockq.h                    |    2 +-
>  src/pulsecore/protocol-esound.c              |    3 ++-
>  src/pulsecore/protocol-http.c                |    2 ++
>  src/pulsecore/protocol-simple.c              |    3 ++-
>  src/pulsecore/sink-input.c                   |    4 ++--
>  src/pulsecore/sound-file-stream.c            |    2 +-
>  16 files changed, 23 insertions(+), 16 deletions(-)

I now applied the first patch. I didn't feel comfortable about applying
the second patch. I filed a bug about the general issue of
pa_memblockq_push() usage, so that this doesn't get forgotten:
https://bugs.freedesktop.org/show_bug.cgi?id=60405

-- 
Tanu