[pulseaudio-discuss] [PATCH v2 0/4] bluetooth: Port names based on form factor

Mikel Astiz mikel.astiz.oss at gmail.com
Mon Mar 4 07:38:30 PST 2013

From: Mikel Astiz <mikel.astiz at bmw-carit.de>

A second proposal integrating some ideas from Tanu and David:
- Hex numbers used for bit masks (patch 2/4).
- Link to the Bluetooth spec added in comment, to clarify magic numbers (patch 2/4).
- Port names improved (patch 3/4).

There was no conclusion about how the port creation should be handled. This patchset doesn't modify the previous codebase in this sense and therefore both input and output ports are created always. This is not fantastic but it's mitigated by the port availability flag, which should clarify if the ports are usable.

>From original cover-letter:

This patchset considers the device's form factor (Bluetooth device class) in order to decide the name and description of the ports.

The approach assumes the form factor of a paired device will remain constant, which seems to be the case in any real-life scenario.

Patch 4/4 simplifies the core by removing dynamic port creation, recently added due to Bluetooth's interests. However, now that we have a slightly different interpretation of ports, this core extension should be reconsidered.

Mikel Astiz (4):
  bluetooth: Use enum to represent form factors
  bluetooth: Add specific form factor for phones
  bluetooth: Use form factor to set port name and description
  Revert "card: Support adding ports dynamically"

 src/modules/bluetooth/bluetooth-util.c          | 78 +++++++++++++++------
 src/modules/bluetooth/bluetooth-util.h          | 16 ++++-
 src/modules/bluetooth/module-bluetooth-device.c | 90 ++++++++++++++++++++++---
 src/modules/module-card-restore.c               | 43 ------------
 src/pulsecore/card.c                            | 19 ------
 src/pulsecore/card.h                            |  1 -
 src/pulsecore/core.h                            |  1 -
 7 files changed, 154 insertions(+), 94 deletions(-)


More information about the pulseaudio-discuss mailing list