[pulseaudio-discuss] [PATCHv2 3/4] module-virtual-source: remove redundant checks and callbacks

[Stefan Huber]

- do not check pa_xnew0()'s return value
- remove redundant source_output_process_msg_cb()
---
 src/modules/module-virtual-source.c |   13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/modules/module-virtual-source.c b/src/modules/module-virtual-source.c
index e713b92..d2489f9 100644
--- a/src/modules/module-virtual-source.c
+++ b/src/modules/module-virtual-source.c
@@ -368,14 +368,6 @@ static void source_output_process_rewind_cb(pa_source_output *o, size_t nbytes)
 }
 
 /* Called from output thread context */
-static int source_output_process_msg_cb(pa_msgobject *obj, int code, void *data, int64_t offset, pa_memchunk *chunk) {
-
-    /* FIXME, nothing to do here ? */
-
-    return pa_source_output_process_msg(obj, code, data, offset, chunk);
-}
-
-/* Called from output thread context */
 static void source_output_attach_cb(pa_source_output *o) {
     struct userdata *u;
 
@@ -529,10 +521,6 @@ int pa__init(pa_module*m) {
     }
 
     u = pa_xnew0(struct userdata, 1);
-    if (!u) {
-        pa_log("Failed to alloc userdata");
-        goto fail;
-    }
     u->module = m;
     m->userdata = u;
     u->memblockq = pa_memblockq_new("module-virtual-source memblockq", 0, MEMBLOCKQ_MAXLENGTH, 0, &ss, 1, 1, 0, NULL);
@@ -612,7 +600,6 @@ int pa__init(pa_module*m) {
     if (!u->source_output)
         goto fail;
 
-    u->source_output->parent.process_msg = source_output_process_msg_cb;
     u->source_output->push = source_output_push_cb;
     u->source_output->process_rewind = source_output_process_rewind_cb;
     u->source_output->kill = source_output_kill_cb;
-- 
1.7.9.5