[pulseaudio-discuss] [PATCH v3 0/4] bluetooth: Port names based on form factor
david.henningsson at canonical.com
Fri Mar 8 09:27:22 PST 2013
On 03/07/2013 11:32 AM, Mikel Astiz wrote:
> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
> Same as v2 but with the changes suggested by David in patch 3/4.
I've now tested and pushed the three first patches, and also an extra:
Thank you for your contribution!
> As discussed in IRC, I would suggest patch 4/4 is not merged yet, even if we agreed on it, to avoid adding and removing features back and forth from the core.
> From original cover-letter:
> This patchset considers the device's form factor (Bluetooth device class) in order to decide the name and description of the ports.
> The approach assumes the form factor of a paired device will remain constant, which seems to be the case in any real-life scenario.
> Patch 4/4 simplifies the core by removing dynamic port creation, recently added due to Bluetooth's interests. However, now that we have a slightly different interpretation of ports, this core extension should be reconsidered.
> Mikel Astiz (4):
> bluetooth: Use enum to represent form factors
> bluetooth: Add specific form factor for phones
> bluetooth: Use form factor to set port name and description
> Revert "card: Support adding ports dynamically"
> src/modules/bluetooth/bluetooth-util.c | 78 +++++++++++++++------
> src/modules/bluetooth/bluetooth-util.h | 16 ++++-
> src/modules/bluetooth/module-bluetooth-device.c | 92 ++++++++++++++++++++++---
> src/modules/module-card-restore.c | 43 ------------
> src/pulsecore/card.c | 19 -----
> src/pulsecore/card.h | 1 -
> src/pulsecore/core.h | 1 -
> 7 files changed, 156 insertions(+), 94 deletions(-)
David Henningsson, Canonical Ltd.
More information about the pulseaudio-discuss