[pulseaudio-discuss] [PATCH v2 1/3] protocol-native: Ensure tlength is not set higher than maxlength

Tanu Kaskinen tanuk at iki.fi
Fri Mar 22 02:07:50 PDT 2013


On Fri, 2013-03-22 at 10:04 +0100, David Henningsson wrote:
> On 03/22/2013 08:39 AM, Tanu Kaskinen wrote:
> > On Thu, 2013-03-21 at 19:10 +0100, David Henningsson wrote:
> >> If tlength is not specified and maxlength is, tlength should never
> >> be set higher than maxlength by default.
> >
> > Shouldn't this be enforced even if tlength is specified?
> 
> Or should instead maxlength be increased to fit the specified tlength? 
> It's a matter of taste.

pa_memblockq adapts tlength to maxlength, so doing the same here would
be more consistent with that. In any case, the patch doesn't ensure that
tlength is always at most maxlength.

-- 
Tanu



More information about the pulseaudio-discuss mailing list