[pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

[Kiran Krishnappa]

Hi Tanu,

Can you please review my new patchset?

Regards,
Kiran


On Thu, Oct 10, 2013 at 8:01 PM, Kiran Krishnappa <kiraank at gmail.com> wrote:

> Hi,
>
> I tested both paplay and parecord for 24bit files. Looks to be working
> fine now.
>
> Regards,
> Kiran
>
>
>
> On Wed, Oct 9, 2013 at 11:30 PM, Kiran Krishnappa <kiraank at gmail.com>wrote:
>
>> PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not
>> handled in pa_sndfile_readf and writef function. paplay/parecord
>> used to get aborted for 24bit depth wav files
>> ---
>>  src/pulsecore/sndfile-util.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/pulsecore/sndfile-util.c b/src/pulsecore/sndfile-util.c
>> index 0820ee4..a951c01 100644
>> --- a/src/pulsecore/sndfile-util.c
>> +++ b/src/pulsecore/sndfile-util.c
>> @@ -384,6 +384,7 @@ pa_sndfile_readf_t pa_sndfile_readf_function(const
>> pa_sample_spec *ss) {
>>
>>          case PA_SAMPLE_ULAW:
>>          case PA_SAMPLE_ALAW:
>> +        case PA_SAMPLE_S24NE:
>>              return NULL;
>>
>>          default:
>> @@ -407,6 +408,7 @@ pa_sndfile_writef_t pa_sndfile_writef_function(const
>> pa_sample_spec *ss) {
>>
>>          case PA_SAMPLE_ULAW:
>>          case PA_SAMPLE_ALAW:
>> +        case PA_SAMPLE_S24NE:
>>              return NULL;
>>
>>          default:
>> --
>> 1.7.9.5
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20131011/65085baf/attachment.html>