[pulseaudio-discuss] [PATCH 1/4] alsa: Add extcon (Android switch) jack detection

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Thu Sep 19 05:05:19 PDT 2013


On Thu, 2013-09-19 at 13:17 +0200, Damir Jelić wrote:
> On Wed, Sep 18, 2013 at 04:01:49PM +0200, David Henningsson wrote:
> > +static struct android_switch *android_switch_new(const char *name) {
> > +
> 
> Now you add here an extra empty line (and in every new function below).
> I've seen such style inside the tree albeit it's fairly uncommon. If we look 
> at the example "good_function" from our coding style[1] there is no empty line
> at the  beginning of the function although it nowhere states that its strictly
> forbidden. Maybe Tanu can shed some light here.

I don't have much to add. I'd prefer to not have the empty line there,
but as long as we don't have it standardized in the coding style
document, I'm not demanding changes either.

-- 
Tanu



More information about the pulseaudio-discuss mailing list