[pulseaudio-discuss] [PATCH 1/4] alsa: Add extcon (Android switch) jack detection

[David Henningsson]

On 09/19/2013 01:17 PM, Damir Jelić wrote:
> Sorry if I'm a little bit annoying here but I'd like to keep our from
> now on with as little style inconsistency as possible. I haven't done
> any proper review/testing on this, just a quick coding style check.

Sorry if I'm even more annoying here ;-) but perhaps you haven't heard
my personal view on this matter.

I totally disagree. I would instead like to keep our coding style rules
to a bare minimum to keep the code decently readable. Anything else is
just an additional road block towards what's important: spending as much
time as possible fixing bugs and implementing new features, rather than
spending time complying to coding style rules.

So; for the opening bracket on newline - I think our current coding
style is wrong and should be changed for functions, and I always forget
that we have this odd style here. You're okay to comment on that,
because it is in our coding style rules, but I would appreciate more, as
you say, "any proper review/testing", rather than a simple coding style
check. You focus on what looks good on the surface, but what really
matters is real code quality - i e, whether the code is going to solve
our users' problems without causing annoying bugs, or not.

> If you're really lazy you can use my sed script to fix this issues (well
> the opening bracket on newline issues at least).[2]

For the stuff that's *not* in the coding style wiki page, I'm even
lazier. If you prefer a different style than I happen to write, feel
free to run your scripts every six months or so and submit a patch for
it, and I won't complain if somebody else reviews and commit it. (Well,
unless it severely decreases readability somehow.)

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic