[pulseaudio-discuss] [PATCH v5 00/39] Refactor of BlueZ 5 support

[João Paulo Rechi Vita]

On Sun, Sep 29, 2013 at 11:24 AM, Tanu Kaskinen
<tanu.kaskinen at linux.intel.com> wrote:
> On Tue, 2013-09-24 at 19:45 -0300, jprvita at gmail.com wrote:
>> From: João Paulo Rechi Vita <jprvita at gmail.com>
>>
>> This series reverts the previous support for BlueZ 5, renames the "bluetooth"
>> portion of the old modules name for "bluez4", creates a new set of modules for
>> BlueZ 5 supporting A2DP sink and source roles, and provides configuration
>> options to independently enable/disable each modules set during build. The
>> transport acquire/release operations have been reworked to provide a way to
>> implement this operations in transport backends out of the bluez5 modules core.
>>
>> João Paulo Rechi Vita (39):
>>   bluetooth: Remove all devices and adapters when org.bluez goes away
>>   bluetooth: Create pa_bluetooth_transport for BlueZ 5 support
>>   bluetooth: Register MediaEndpoint1 objects with D-Bus
>>   bluetooth: Implement org.bluez.MediaEndpoint1.SetConfiguration()
>>   bluetooth: Implement org.bluez.MediaEndpoint1.SelectConfiguration()
>>   bluetooth: Implement org.bluez.MediaEndpoint1.ClearConfiguration()
>>   bluetooth: Add utility function to send D-Bus messages with reply
>>   bluetooth: Get managed objects
>>   bluetooth: Create a function to remove only one adapter object
>>   bluetooth: Handle InterfacesAdded and InterfacesRemoved
>>   bluetooth: Parse BlueZ 5 D-Bus interfaces
>>   bluetooth: Parse BlueZ 5 adapter properties
>>   bluetooth: Register endpoints with BlueZ 5 adapter
>>   bluetooth: Handle PropertiesChanged for org.bluez.Adapter1
>>   bluetooth: Parse BlueZ 5 device properties
>>   bluetooth: Protect from a misbehaving bluetoothd
>>   bluetooth: Handle PropertiesChanged for org.bluez.Device1
>>   bluetooth: Handle PropertiesChanged for org.bluez.MediaTransport1
>>   bluetooth: Track devices in module-bluez5-discover
>>   bluetooth: Create module-bluez5-device
>>   bluetooth: Get BlueZ 5 device object
>>   bluetooth: Unload module-bluez5-device on device's disconnection
>>   bluetooth: Create BlueZ 5 card
>>   bluetooth: Create BlueZ 5 card ports
>>   bluetooth: Create BlueZ 5 card profile for each audio UUID
>>   bluetooth: Initialize profiles for BlueZ 5 cards
>>   bluetooth: Create sink for BlueZ 5 cards
>>   bluetooth: Create source for BlueZ 5 cards
>>   bluetooth: Start / stop I/O thread for BlueZ 5 cards
>>   bluetooth: Set card profile for BlueZ 5 cards
>>   bluetooth: Create I/O thread function for BlueZ 5 cards
>>   bluetooth: Process sink messages for BlueZ 5 cards
>>   bluetooth: Process source messages for BlueZ 5 cards
>>   bluetooth: Handle changes to BlueZ 5 transports state
>>   bluetooth: Implement get_n_used() for module-bluez5-device
>>   bluetooth: Fail to load driver if discovery module is not loaded
>>   module: Create pa_module_exists()
>>   cli-command: Use pa_module_exists() in .ifexists
>>   bluetooth: Revive module-bluetooth-discover
>>
>>  configure.ac                                      |    1 +
>>  src/Makefile.am                                   |   20 +-
>>  src/modules/bluetooth/bluez5-util.c               | 1352 ++++++++++++++-
>>  src/modules/bluetooth/bluez5-util.h               |   53 +
>>  src/modules/bluetooth/module-bluetooth-discover.c |   78 +
>>  src/modules/bluetooth/module-bluez5-device.c      | 1898 +++++++++++++++++++++
>>  src/modules/bluetooth/module-bluez5-discover.c    |   52 +
>>  src/pulsecore/cli-command.c                       |   41 +-
>>  src/pulsecore/module.c                            |   55 +
>>  src/pulsecore/module.h                            |    2 +
>>  10 files changed, 3501 insertions(+), 51 deletions(-)
>>  create mode 100644 src/modules/bluetooth/module-bluetooth-discover.c
>>  create mode 100644 src/modules/bluetooth/module-bluez5-device.c
>
> I pushed all to master now. I'll post separate patches for the remaining
> small issues. Thanks for your persistence with getting these patches
> polished!
>

That's great! I'll answer the remaining comments and send necessary
fixes (but feel free to send patches as well). I plan to stick around
maintaining this code, so you can ping/cc me on issues related with
this code.

I'll still have the ofono-HFP sitting on a local branch here, which
I'll send after we finish with the remaining points of the refactor.

-- 
João Paulo Rechi Vita
http://about.me/jprvita