[pulseaudio-discuss] [PATCH] module-stream-restore: use entry_write when filling up the database

[Ricardo Salveti]

On Fri, Oct 3, 2014 at 3:37 AM, David Henningsson
<david.henningsson at canonical.com> wrote:
> Hi Ricardo and thanks for the patch,
>
> Could you give some context - is this just a refactoring patch?

Fixing a bug actually. It seems at some point the code migrated to use
the entry_write calls, but fill_db is still using the old syntax,
causing the entry to be invalid.

The crash happens when clean_up_db gets called, which then calls
entry_read, causing the crash. entry_write correctly sets up struct
and db, so that's why I changed that.

> Because there is launchpad bug [1], and the suspicious text "Temporarily
> disabling fallback table as that can get pulse in a crash loop without the
> fix available in pulseaudio 1:4.0-0ubuntu21" but there is no 1:4.0-0ubuntu21
> version of PulseAudio anywhere I can find...

1:4.0-0ubuntu21 is still stuck in the queue (since we're in freeze
mode). I had to disable the fallback table because it only works with
this patch.

Cheers,
-- 
Ricardo Salveti de Araujo