[pulseaudio-discuss] [PATCH] module-stream-restore: use entry_write when filling up the database

[David Henningsson]

On 2014-10-03 11:31, Ricardo Salveti wrote:
> On Fri, Oct 3, 2014 at 3:37 AM, David Henningsson
> <david.henningsson at canonical.com> wrote:
>> Hi Ricardo and thanks for the patch,
>>
>> Could you give some context - is this just a refactoring patch?
>
> Fixing a bug actually. It seems at some point the code migrated to use
> the entry_write calls, but fill_db is still using the old syntax,
> causing the entry to be invalid.
>
> The crash happens when clean_up_db gets called, which then calls
> entry_read, causing the crash. entry_write correctly sets up struct
> and db, so that's why I changed that.

Cool, thanks for the explanation. I have committed your fix to upstream now.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic