[pulseaudio-discuss] [PATCH 2/6] log: Fix compilation error when HAVE_SYSLOG_H is undefined

Tanu Kaskinen tanuk at iki.fi
Tue Apr 19 13:16:27 UTC 2016


On Sun, 2016-03-13 at 23:57 +0200, Ahmed S. Darwish wrote:
> Signed-off-by: Ahmed S. Darwish <darwish.07 at gmail.com>
> ---
>  src/pulsecore/log.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/pulsecore/log.c b/src/pulsecore/log.c
> index b5db818..0c561e8 100644
> --- a/src/pulsecore/log.c
> +++ b/src/pulsecore/log.c
> @@ -525,7 +525,6 @@ void pa_log_levelv_meta(
>  
>                      saved_errno = errno;
>                      fprintf(stderr, "%s\n", "Error writing logs to the journal. Redirect log messages to console.");
> -                    fprintf(stderr, "%s %s\n", metadata, t);
>  #endif
>                      pa_log_set_target(&new_target);
>                  }

The commit message is a bit short on information. What's the
compilation error? And why is it a good idea to drop the log message
altogether?

-- 
Tanu


More information about the pulseaudio-discuss mailing list