[pulseaudio-discuss] [PATCH v3 14/24] build-sys: Move to compiling with C11 support

Tanu Kaskinen tanuk at iki.fi
Wed Feb 3 20:04:59 PST 2016


On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote:
> @@ -176,6 +175,8 @@ esac
>  
>  #### Compiler flags ####
>  
> +AX_CHECK_COMPILE_FLAG([-std=c11], [CFLAGS="$CFLAGS -std=c11"], [], [-pedantic -Werror])

This does nothing if the compile flag isn't supported. Shouldn't we
fail in configure if -std=c11 doesn't work?

Also, I don't think we should set CFLAGS. Adding -std=c11 to AM_CFLAGS
in src/Makefile.am seems like the right thing to do. See
https://www.gnu.org/software/automake/manual/html_node/User-Variables.html#User-Variables

-- 
Tanu


More information about the pulseaudio-discuss mailing list