[pulseaudio-discuss] [PATCH 1/2] SunOS: Catch up with newer API

[Arun Raghavan]

On Mon, 2016-01-18 at 08:04 +0100, Kamil Rytarowski wrote:
> On 18.01.2016 05:21, Arun Raghavan wrote:
> > On Fri, 2016-01-15 at 14:33 +0100, Kamil Rytarowski wrote:
> > > On 12.01.2016 04:08, Arun Raghavan wrote:
> > > > On 11 January 2016 at 19:37, David Henningsson 
> > > > <david.henningsson at canonical.com> wrote:
> > > > > Hi,
> > > > > 
> > > > > this patch seems to need further explanation.
> > > > > 
> > > > > I e, what "newer API", and why have we added a set_mute call
> > > > > in some places after get_mute and not others?
> > > > 
> > > > Probably just needs to reference commit 
> > > > e4a7625ba884c5cce20468d75937857343751c35
> > > > 
> > > > http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=e4
> > > > a762
> > > > 
> > > > 
> 5ba
> > > 884c5cce20468d75937857343751c35
> > > > 
> > > > 
> > > Is there still need to improve the patch?
> > 
> > Not really, though I think I'd prefer to exchange the author and 
> > attribution (i.e. Jonathan as author, and your contribution
> > mentioned in the commit message). I'll fix that up and mention the
> > earlier commit if there are no objections.
> 
> Well,
> 
> Jonathan's added original patches to pkgsrc regarding this platform.
> SunOS 1/2 is unmodified his work.
> SunOS 2/2 was reworked by myself, I changed the code from #ifdef
> __sunos #endif to autoconf checks.
> 
> I'm OK with your proposal as long as it will be merged and delta
> between pkgsrc and upstream reduced.

Done on both counts.

-- Arun