[pulseaudio-discuss] [PATCH] ladspa-sink: avoid to configure invalid format

[Arun Raghavan]

On Thu, 19 May 2016, at 08:05 AM, KimJeongYeon wrote:
> LADSPA allows float format only, but module-ladspa-sink possibly
> could be loaded with ***any*** 'format' parameter. Therefore noisy
> sound heard. This patch avoids to be configured as invalid format.
> 
> Signed-off-by: KimJeongYeon <jeongyeon.kim at samsung.com>
> ---
>  src/modules/module-ladspa-sink.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/modules/module-ladspa-sink.c
> b/src/modules/module-ladspa-sink.c
> index 38b94e3..a6290b9 100644
> --- a/src/modules/module-ladspa-sink.c
> +++ b/src/modules/module-ladspa-sink.c
> @@ -981,6 +981,11 @@ int pa__init(pa_module*m) {
>          goto fail;
>      }
>  
> +    if (ss.format != PA_SAMPLE_FLOAT32) {
> +        pa_log("LADSPA accepts float format only");
> +        goto fail;
> +    }
> +
>      if (!(plugin = pa_modargs_get_value(ma, "plugin", NULL))) {
>          pa_log("Missing LADSPA plugin name");
>          goto fail;
> -- 

Pushing to 'next' and it'll be merged into master after we release 9.0,
thanks!

-- Arun