[pulseaudio-discuss] [PATCH] ladspa-sink: avoid to configure invalid format

KimJeongYeon jeongyeon.kim at samsung.com
Thu May 19 02:35:44 UTC 2016


LADSPA allows float format only, but module-ladspa-sink possibly
could be loaded with ***any*** 'format' parameter. Therefore noisy
sound heard. This patch avoids to be configured as invalid format.

Signed-off-by: KimJeongYeon <jeongyeon.kim at samsung.com>
---
 src/modules/module-ladspa-sink.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/modules/module-ladspa-sink.c b/src/modules/module-ladspa-sink.c
index 38b94e3..a6290b9 100644
--- a/src/modules/module-ladspa-sink.c
+++ b/src/modules/module-ladspa-sink.c
@@ -981,6 +981,11 @@ int pa__init(pa_module*m) {
         goto fail;
     }
 
+    if (ss.format != PA_SAMPLE_FLOAT32) {
+        pa_log("LADSPA accepts float format only");
+        goto fail;
+    }
+
     if (!(plugin = pa_modargs_get_value(ma, "plugin", NULL))) {
         pa_log("Missing LADSPA plugin name");
         goto fail;
-- 
2.7.4



More information about the pulseaudio-discuss mailing list