[pulseaudio-discuss] [PATCH v6 22/25] loopback: Allow shorter adjust_time
tanuk at iki.fi
Mon Sep 5 15:14:42 UTC 2016
On Sun, 2016-06-05 at 21:05 +0200, Georg Chini wrote:
> Allow shorter adjust times than 1s.
> In order to not break the existing API, values below 100 will still be
> considered to be seconds, while values greater or equal 100 will be ms.
> This allows to specify adjust times as low as 100 ms.
Having two interpretations isn't nice; I would prefer a new
"adjust_time_msec" argument, or using a decimal number. However, this
is not a big issue, so if you anyway want to do this your way, I'm not
going to stop you.
The commit message doesn't answer the question that every commit
message should answer: "why is this done?"
> -#define DEFAULT_ADJUST_TIME_USEC (10*PA_USEC_PER_SEC)
> +#define DEFAULT_ADJUST_TIME_USEC (1*PA_USEC_PER_SEC)
This change is not mentioned at all in the commit message. The reason
for changing the default should be stated.
More information about the pulseaudio-discuss