[pulseaudio-discuss] [PATCH v6 25/25] loopback: Add log_interval parameter

Tanu Kaskinen tanuk at iki.fi
Tue Sep 6 19:19:59 UTC 2016


On Tue, 2016-09-06 at 14:30 +0200, Georg Chini wrote:
> On 06.09.2016 11:47, Tanu Kaskinen wrote:
> > 
> > On Sun, 2016-06-05 at 21:05 +0200, Georg Chini wrote:
> > > 
> > > Add a log_interval parameter to control the amount of logging. Default is
> > > no logging. Like the adjust_time parameter, values below 100 are considered
> > > seconds while larger values are ms. If the log interval is too small, logging
> > > will occur on every iteration.
> > The commit message doesn't answer the question why this change is done.
> > Otherwise looks good to me, although if you change the adjust_time to
> > not use the millisecond/second semantics, this parameter needs to be
> > changed too.
> > 
> Thanks a lot for your thorough review. It will take a while until I send the
> next version, I had some ear surgery a couple of days ago and there is
> also an upcoming vacation.

Ear surgery doesn't sound fun, unless it was for adding an implant for
gaining a superhuman hearing ability... Thanks for your continued
contributions!

-- 
Tanu


More information about the pulseaudio-discuss mailing list