[pulseaudio-discuss] [PATCH] Don't abort on double module load

[Colin Leroy]

Hello,

I recently had to investigate quite a bit why PulseAudio started to
abort on my computer, and finally figured out the reason :

- I had "module-load module-raop-discover" set in /etc/pulse/default.pa
- I fiddled with `paprefs` while PA was running and checked "Make
  discoverable Apple AirTunes sound devices available locally"
- This triggered a load of module-raop-discover via module-gconf, which
  failed silently because the module was already loaded:

D: [pulseaudio] module-gconf.c: Loading module 'module-raop-discover'
  with args '' due to GConf configuration.
E: [pulseaudio] module.c: Module "module-raop-discover" should be
  loaded once at most. Refusing to load.
E: [pulseaudio] module-gconf.c: pa_module_load() failed

- At the next reboot, module-raop-discover was loaded via module-gconf,
  then cli-command tried to load it again, failed and PulseAudio exited.

The attached patch fixes it by adding an optional error code pointer to
pa_module_load(), and checking for the error code in cli-command.

I don't know if this is an acceptable solution for the PulseAudio team,
I'm not even sure that's a case you want to handle, but I thought it
would be worth it to mention this problem to you, gather your input
on the subject and come up with an idea to handle it.

Thanks,
-- 
Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CLI-Don-t-exit-on-module-already-loaded-errors.patch
Type: text/x-patch
Size: 21040 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170826/b9473f29/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170826/b9473f29/attachment-0001.sig>