[pulseaudio-discuss] Coverity scan

[Philip Withnall]

Hi,

On Wed, 2017-02-22 at 12:38 +0100, Peter Meerwald-Stadler wrote:
> as written and discussed before (
> https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-Septem
> ber/024378.html
> http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/19270
> http://pulseaudio-discuss.freedesktop.narkive.com/RH83JeQl/coverity-a
> nd-pa-asser-se
> ) I think we need to teach Coverity scan about the semantics of 
> pa_assert_se()
> 
> this can be done in Coverity's config/user_nodefs.h, this is a local 
> change to the Coverity installation (it sucks)
> 
> please have below line in your Coverity setup when submitting a
> build:
> #nodef pa_assert_se(uniquex) do { int uniquey = uniquex ; if
> (!(uniquey)) __coverity_panic__(); } while (0)

Apologies if this has been discussed before (I don’t follow PulseAudio
development), but why not stick this in the server-side Coverity
modelling file? Does that not work?

Failing that, there’s the __COVERITY__ macro which could be used to
change the definition of pa_assert_se() in upstream git:
https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/prevent-4.3.1/i386
_linux26/opt/prevent-linux-4.3.1/doc/prevent_admin.html#N40430

> ideally, this should be on a build server which also has a fixed set
> of 
> libraries and configure options...

PulseAudio is set up to be built on jenkins.freedesktop.org using
JHBuild, and for Coverity submissions to be made from that once a week.
It’s a stable set of configure options, and depends on whatever else is
built in JHBuild at the time (generally git master of everything),
which means that the generated reports are relevant to current
development.

Philip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170222/9ecd863e/attachment.sig>