[pulseaudio-discuss] [PATCH v2 08/10] raop: Silence unchecked return value warnings

[Hajime Fujita]

> On Mar 6, 2017, at 1:43 AM, Peter Meerwald-Stadler <pmeerw at pmeerw.net> wrote:
> 
> Signed-off-by: Peter Meerwald-Stadler <pmeerw at pmeerw.net>
> ---
> src/modules/raop/raop-client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c
> index c6e1877..d329a09 100644
> --- a/src/modules/raop/raop-client.c
> +++ b/src/modules/raop/raop-client.c
> @@ -1034,9 +1034,9 @@ static void rtsp_stream_cb(pa_rtsp_client *rtsp, pa_rtsp_state_t state, pa_rtsp_
>                         if ((pc = strstr(token, "="))) {
>                             *pc = 0;
>                             if (pa_streq(token, "control_port"))
> -                                pa_atou(pc + 1, &cport);
> +                                (void) pa_atou(pc + 1, &cport);
>                             if (pa_streq(token, "timing_port"))
> -                                pa_atou(pc + 1, &tport);
> +                                (void) pa_atou(pc + 1, &tport);

I think these should jump to `setup_error` in case of error instead of ignoring.

>                             *pc = '=';
>                         }
>                         pa_xfree(token);
> -- 
> 2.7.4
> 
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss