[pulseaudio-discuss] [PATCH v2 08/10] raop: Silence unchecked return value warnings

[Peter Meerwald-Stadler]

> > --- a/src/modules/raop/raop-client.c
> > +++ b/src/modules/raop/raop-client.c
> > @@ -1034,9 +1034,9 @@ static void rtsp_stream_cb(pa_rtsp_client *rtsp, pa_rtsp_state_t state, pa_rtsp_
> >                         if ((pc = strstr(token, "="))) {
> >                             *pc = 0;
> >                             if (pa_streq(token, "control_port"))
> > -                                pa_atou(pc + 1, &cport);
> > +                                (void) pa_atou(pc + 1, &cport);
> >                             if (pa_streq(token, "timing_port"))
> > -                                pa_atou(pc + 1, &tport);
> > +                                (void) pa_atou(pc + 1, &tport);
> 
> I think these should jump to `setup_error` in case of error instead of ignoring.

I've posted a followup patch implementing your suggestion; strictly, this 
is adding functionality to the code, so maybe better to do it in two 
patches anyway :)

regards, p.

-- 

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418