[pulseaudio-discuss] bug in vala binding

[wellington wallace]

On Mon, Apr 23, 2018 at 1:23 PM, wellington wallace <
wellingtonwallace at gmail.com> wrote:

> Hi PA developers!
>
> Something doesn't seem right in the vala binding. The struct
> "SourceOutputInfo" has a property named "sink_usec" when it should be
> "source_usec". The same naming error can be seen in the binding docs
> https://valadoc.org/libpulse/PulseAudio.SourceOutputInfo.html. Vala
> compiler aborts compilation using both "sink_usec" or "source_usec" as the
> property name.
>
> Best regards,
>              Wellington
>
> --
> Prof.° Wellington Wallace Miguel Melo
>
> CEFET/RJ Uned Nova Iguaçu
>
>
The patch below fixes the problem and adds to the vala bindings two missing
source_output functions. As I have never sent patches to anyone before I am
not sure if this is the proper way.

--- libpulse.vapi 2018-04-24 01:20:24.857485070 -0300
+++ libpulse_new.vapi 2018-04-24 01:28:41.627503634 -0300
@@ -1077,6 +1077,9 @@

                 public Operation? set_sink_input_volume(uint32 idx,
CVolume volume, SuccessCb? cb = null);
                 public Operation? set_sink_input_mute(uint32 idx, bool
mute, SuccessCb? cb = null);
+
+                public Operation? set_source_output_volume(uint32 idx,
CVolume volume, SuccessCb? cb = null);
+                public Operation? set_source_output_mute(uint32 idx, bool
mute, SuccessCb? cb = null);

                 public Operation? kill_sink_input(uint32 idx, SuccessCb?
cb = null);

@@ -1404,7 +1407,7 @@
                 public SampleSpec sample_spec;
                 public ChannelMap channel_map;
                 public uint32 buffer_usec;
-                public uint32 sink_usec;
+                public uint32 source_usec;
                 public string resample_method;
                 public string driver;
                 public Proplist proplist;

-- 
Prof.° Wellington Wallace Miguel Melo

CEFET/RJ Uned Nova Iguaçu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180424/5b088891/attachment.html>