[pulseaudio-discuss] [PATCH v2 2/2] Bluetooth A2DP aptX codec support

[Pali Rohár]

On Tuesday 18 September 2018 13:55:08 Luiz Augusto von Dentz wrote:
> Hi Pali,
> 
> On Mon, Sep 17, 2018 at 3:27 PM, Tanu Kaskinen <tanuk at iki.fi> wrote:
> > On Thu, 2018-09-13 at 11:12 +0200, Pali Rohár wrote:
> >> On Wednesday 05 September 2018 13:57:08 Tanu Kaskinen wrote:
> >> > > +#### Bluetooth A2DP aptX codec (optional) ###
> >> > > +
> >> > > +AC_ARG_ENABLE([aptx],
> >> > > +    AS_HELP_STRING([--disable-aptx],[Disable optional bluetooth A2DP aptX codec support (via libopenaptx)]))
> >> > > +
> >> > > +AS_IF([test "x$HAVE_BLUEZ_5" = "x1" && test "x$enable_aptx" != "xno"],
> >> > > +    [AC_CHECK_HEADER([openaptx.h],
> >> > > +        [AC_CHECK_LIB([openaptx], [aptx_init], [HAVE_OPENAPTX=1], [HAVE_OPENAPTX=0])],
> >> > > +        [HAVE_OPENAPTX=0])])
> >> >
> >> > Have you considered providing a .pc file? Now we have to hardcode the
> >> > openaptx specific CFLAGS and LIBADD for libbluez5-util. If you ever
> >> > need to add new flags, all openaptx users need to update their build
> >> > systems. Also, if the library is installed to a non-standard location,
> >> > the .pc file can set the -L and -I flags to point to the right place.
> >>
> >> Intension is that library is small and does not need any special cflags
> >> or ldflags. So .pc file is not needed at all. And if library or include
> >> file is in non-standard location then user really need to specify where
> >> it is. But same argument can be used when .pc file is in non-standard
> >> location. User again need to do some magic.
> 
> Long term I think it is best to use autotools to properly generate the
> .pc file, etc, otherwise it might be difficult for distros to pick
> this up. I might be able to help you with that if you are willing to
> accept patches.

Because I know autotools, how to use it and how it works, I'm saying No.
For small library I explicitly chose something which is easy and not big
hell moloch. I really do not need anything special nor any custom or
specific functionality. Also library has no dependences.

-- 
Pali Rohár
pali.rohar at gmail.com