[Bug 63807] No way to filter devices

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Apr 26 07:43:49 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=63807

Zeeshan Ali <zeenix at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Zeeshan Ali <zeenix at gmail.com> ---
(In reply to comment #1)
> This is fixed by this commit, closing:
> http://cgit.freedesktop.org/spice/spice-gtk/commit/
> ?id=0ebcc23c0642d2bddcb05ed4152497c99cb3ca1d

Sorry but you are not getting away that easy. :) As I pointed out on IRC, its a
very ugly API if you are asking apps to give you a very cryptic string for
filter. Surely you can add some enums/flags and allow apps to filter through
that. If you fail in that, at the very least add some docs explaining the
syntax of the filter string you are expecting from apps.

Also, I think the name is long enough so I suggest renaming this function to:
pice_usb_device_manager_get_devices_filtered() but this is just a suggestion.
Ignore if you don't agree. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-bugs/attachments/20130426/18a61ce1/attachment.html>


More information about the spice-bugs mailing list