[Spice-commits] 3 commits - meson.build

[GitLab Mirror]

 meson.build |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 443734830a899095a5f04774df5513dcfb4abe69
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 09:05:37 2020 +0000

    build: Use warning_level option for Meson
    
    warning_level 2 setting for Meson add the same "-Wall -Wextra"
    options to GCC compiler.
    This removes a warning using Meson.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/meson.build b/meson.build
index e0dcca8..6b0e71a 100644
--- a/meson.build
+++ b/meson.build
@@ -5,7 +5,8 @@ project('spice-gtk', 'c',
          version : run_command('build-aux/git-version-gen', '@0@/.tarball-version'.format(meson.source_root()), check : true).stdout().strip(),
          license : 'LGPLv2.1',
          meson_version : '>= 0.49',
-         default_options : ['buildtype=debugoptimized'])
+         default_options : ['buildtype=debugoptimized',
+                            'warning_level=2'])
 
 meson.add_dist_script('build-aux/meson-dist', meson.project_version(), meson.source_root())
 
@@ -20,8 +21,6 @@ spice_gtk_includedir = spice_gtk_prefix / get_option('includedir')
 spice_gtk_global_cflags = ['-DHAVE_CONFIG_H',
                            '-DSPICE_COMPILATION',
                            '-DG_LOG_DOMAIN="GSpice"',
-                           '-Wall',
-                           '-Wextra',
                            '-Wno-sign-compare',
                            '-Wno-unused-parameter',
                            '-Wno-cast-function-type']
commit d24a68422ebd16ed23a12a8c4920b1e9bf28707d
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 09:03:46 2020 +0000

    build: By default use debugoptimized build type for Meson
    
    Usually the default options for C are "-O2 -g".
    So this build type is more conservative.
    Normal users wanting to build the package won't find themselves
    with a bad performance executable.
    This will catch some potentially warning not detected with
    debug build.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/meson.build b/meson.build
index ee4624e..e0dcca8 100644
--- a/meson.build
+++ b/meson.build
@@ -4,7 +4,8 @@
 project('spice-gtk', 'c',
          version : run_command('build-aux/git-version-gen', '@0@/.tarball-version'.format(meson.source_root()), check : true).stdout().strip(),
          license : 'LGPLv2.1',
-         meson_version : '>= 0.49')
+         meson_version : '>= 0.49',
+         default_options : ['buildtype=debugoptimized'])
 
 meson.add_dist_script('build-aux/meson-dist', meson.project_version(), meson.source_root())
 
commit 583b618bf735fc187c06314c70b462358b6668c3
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 08:59:18 2020 +0000

    build: Cleanup old comment
    
    In Meson better to use --werror option instead to manually add to
    options
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>

diff --git a/meson.build b/meson.build
index e7df9c4..ee4624e 100644
--- a/meson.build
+++ b/meson.build
@@ -19,7 +19,6 @@ spice_gtk_includedir = spice_gtk_prefix / get_option('includedir')
 spice_gtk_global_cflags = ['-DHAVE_CONFIG_H',
                            '-DSPICE_COMPILATION',
                            '-DG_LOG_DOMAIN="GSpice"',
-                           #'-Werror',
                            '-Wall',
                            '-Wextra',
                            '-Wno-sign-compare',