[Spice-commits] 3 commits - meson.build

[GitLab Mirror]

 meson.build |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit a59cfc0cc3f7b938712bb37e6bf51aeaa00daba9
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 09:05:37 2020 +0000

    build: Use warning_level option for Meson
    
    warning_level 2 setting for Meson add the same "-Wall -Wextra"
    options to GCC compiler.
    This removes a warning using Meson.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

diff --git a/meson.build b/meson.build
index bb99e4f0..b16e845a 100644
--- a/meson.build
+++ b/meson.build
@@ -5,7 +5,8 @@ project('spice', 'c',
         version : run_command('build-aux/git-version-gen', meson.source_root() + '/.tarball-version', check : true).stdout().strip(),
         license : 'LGPLv2.1',
         meson_version : '>= 0.48',
-        default_options : ['buildtype=debugoptimized'])
+        default_options : ['buildtype=debugoptimized',
+                           'warning_level=2'])
 
 message('Updating submodules')
 run_command('build-aux/meson/check-spice-common', check : true)
@@ -39,8 +40,6 @@ message('libspice.so version: ' + spice_server_so_version)
 # some global vars
 spice_server_global_cflags = ['-DSPICE_SERVER_INTERNAL',
                               '-DG_LOG_DOMAIN="Spice"',
-                              '-Wall',
-                              '-Wextra',
                               '-Wno-sign-compare',
                               '-Wno-unused-parameter']
 
commit ac38d4bbf94655014b003f1c746b13f9b5df8e74
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 09:03:46 2020 +0000

    build: By default use debugoptimized build type for Meson
    
    Usually the default options for C are "-O2 -g".
    So this build type is more conservative.
    Normal users wanting to build the package won't find themselves
    with a bad performance executable.
    This will catch some potentially warning not detected with
    debug build.
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

diff --git a/meson.build b/meson.build
index 7cad72e5..bb99e4f0 100644
--- a/meson.build
+++ b/meson.build
@@ -4,7 +4,8 @@
 project('spice', 'c',
         version : run_command('build-aux/git-version-gen', meson.source_root() + '/.tarball-version', check : true).stdout().strip(),
         license : 'LGPLv2.1',
-        meson_version : '>= 0.48')
+        meson_version : '>= 0.48',
+        default_options : ['buildtype=debugoptimized'])
 
 message('Updating submodules')
 run_command('build-aux/meson/check-spice-common', check : true)
commit 7a4ca27f98002f34b0be8810265a09cc4dc08f29
Author: Frediano Ziglio <fziglio at redhat.com>
Date:   Mon Mar 9 08:59:18 2020 +0000

    build: Cleanup old comment
    
    In Meson better to use --werror option instead to manually add to
    options
    
    Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
    Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

diff --git a/meson.build b/meson.build
index f8f89798..7cad72e5 100644
--- a/meson.build
+++ b/meson.build
@@ -38,7 +38,6 @@ message('libspice.so version: ' + spice_server_so_version)
 # some global vars
 spice_server_global_cflags = ['-DSPICE_SERVER_INTERNAL',
                               '-DG_LOG_DOMAIN="Spice"',
-                              #'-Werror',
                               '-Wall',
                               '-Wextra',
                               '-Wno-sign-compare',