[Spice-devel] spice for upstream qemu

[Alexander Larsson]

On Mon, 2010-04-12 at 13:32 +0200, Gerd Hoffmann wrote:

> > shlib major:
> >
> > -	-version-number $(SPICE_LT_VERSION)	\
> > +	-version-number 1:0:0			\
> >
> > This is not right. We should change configure.ac to have the right
> > libtool version style for SPICE_LT_VERSION, not hardcode it in the
> > Makefile.
> 
> Right now it just uses the spice version, which is wrong IMHO and must 
> be fixed.  I'm not familiar enougth with the auto* tools to handle this 
> in a better way though.

Just change this in configure.ac:

SPICE_LT_VERSION=m4_format("%d:%d:%d", SPICE_MAJOR, SPICE_MINOR, SPICE_MICRO)
AC_SUBST(SPICE_LT_VERSION)

Instead of hardcoding it in the Makefile.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a hate-fuelled soccer-playing grifter with no name. She's a plucky 
French-Canadian Hell's Angel looking for love in all the wrong places. They 
fight crime!