[Spice-devel] [PATCH] spice: vdagent: virtio serial adaptations

[Alexander Larsson]

On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote:
> From: Arnon Gilboa <agilboa at agilboa.usersys.redhat.com>

Overall this looks good to me, although its hard to read in places due
to whitespace-only changes in some places.

It would be good to split it up in independent parts though, to make the
history easier to read etc.

> -mostly based on Alon's patches with cleanup
> -adapt vdi_port class to virtio serial
> -replace vdi_port callbacks with events
> -add get_device_path() - using  setupapi.lib
> -add struct VDIPortBuffer for read/write buffers
> -add VD_EVENT_XXX enum for clarity
> -add DEBUG_VDSERVICE for debugging as standalone executable
> -add CLIPBOARD_ENABLED ifdefs in the agent for disabling clipboard support
> -remove mutex.h usage, deines in vdcommon.h instead

> -include the common spice/vd_agent.h
Isn't this just reverting the previous patch that changes from
vd_agent.h to vdagent.h? Anyway, we should have one single patch that
fixes this to the right end state.



-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a gun-slinging one-eyed senator for the 21st century. She's a 
green-fingered kleptomaniac nun living on borrowed time. They fight crime!