[Spice-devel] [PATCH 02/18] channel security cleanup

[Alexander Larsson]

On Mon, 2010-03-29 at 17:08 +0200, Gerd Hoffmann wrote:
> drop spice_channel_name_t enum, use spice-protocol defines instead.

Hmm, i actually added the spice_channel_name_t enum when pushing this
upstream for two reasons:

1) the other enum doesn't have the ALL item.

2) I'm not sure we want to have a dependency on spice-protocol in the
public headers of the libspice-server api. spice-protocol is really more
meant to be a place to put things common between the different parts of
the spice implementation (client, server, drivers, qemu drivers).

I see you didn't add an include of the spice-protocol headers to the
spice.h header, so how are apps supposed to know what values to use?

Maybe it would be better to have:

int spice_server_set_channel_security(SpiceServer *s, char *channel,
                                      int security);
int spice_server_set_default_channel_security(SpiceServer *s, 
					     int security);

As the public API?

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a lounge-singing overambitious shaman who knows the secret of the alien 
invasion. She's a psychotic mutant lawyer with a flame-thrower. They fight 
crime!