[Spice-devel] [PATCH 02/18] channel security cleanup

[Gerd Hoffmann]

On 03/31/10 11:31, Alexander Larsson wrote:
> On Mon, 2010-03-29 at 17:08 +0200, Gerd Hoffmann wrote:
>> drop spice_channel_name_t enum, use spice-protocol defines instead.
>
> Hmm, i actually added the spice_channel_name_t enum when pushing this
> upstream for two reasons:
>
> 1) the other enum doesn't have the ALL item.

temporary rhel6 hack ;)

> 2) I'm not sure we want to have a dependency on spice-protocol in the
> public headers of the libspice-server api. spice-protocol is really more
> meant to be a place to put things common between the different parts of
> the spice implementation (client, server, drivers, qemu drivers).

Ok.

> int spice_server_set_channel_security(SpiceServer *s, char *channel,
>                                        int security);
> int spice_server_set_default_channel_security(SpiceServer *s,
> 					     int security);

Works for me.  We could even drop 
spice_server_set_default_channel_security() and use channel == NULL for 
"set default".

cheers,
   Gerd