[Spice-devel] [PATCH spice] spicec: Do not try to do accounting of pci memory

[Hans de Goede]

Hi,

On 10/10/2010 05:39 PM, Arnon Gilboa wrote:
> Hans de Goede wrote:
>> Without this patch spicec reproducely hangs in
>> GlzDecoderWindow::pre_decode_update_window().
>>
>> When GlzDecoderWindow::will_overflow() returns true,
>> GlzDecoderWindow::pre_decode_update_window(),
>> waits for a call to GlzDecoderWindow::post_decode()
>> to free up some memory
>>
>> This happens even though there still is pci memory
>> available (otherwise the driver would not have
>> been able to send an image to decode in the first
>> place).
>>
>> The GlzDecoderWindow::post_decode() call never happens
>> as the server is waiting for a reply to the decode
>> of the hanging image, causing the client to hang
>> for ever.
>>
>> This patch fixes this by simply removing the
>> "attempted" pci memory accounting. As there is no
>> need for that, as the driver already must keep
>> track of pci memory usage.
> Can you please expand on this point from the driver side?
> I think nobody here is that familiar with Yonit's global LZ history-based dictionary flow.
> Assuming you are right and the accounting is both unnecessary & buggy, the patch deserves a double ack.

Please see my reply to Gerd's review.

<snip>

Thanks & Regards,

Hans