[Spice-devel] VideoStream - MJpeg Encode/Decode.

Naga Mohan Pothula nagamohan.pothula at yahoo.com
Wed Dec 28 00:04:47 PST 2011

Hi Alon,

After encoding the frame, the width and height of the frame would be changed. I haven't find producing Frame rect in Even format at Encoder.
"red_display_marshall_stream_start" function at encoder receives ODD format Frame rect and this frame rect is continued in "red_marshall_stream_data" function before and after encoding frame. This ODD format frame rect is transferred to Spice client.

Decoder receives ODD format frame rects for below scenario. 
Spice session crash happens if we do mouse hover
on next playing videos list while playing youtube videos in windows guest.

If I remove assertion(just for test) at decoder, everything works fine. 


 From: Alon Levy <alevy at redhat.com>
To: Naga Mohan Pothula <nagamohan.pothula at yahoo.com> 
Cc: "spice-devel at lists.freedesktop.org" <spice-devel at lists.freedesktop.org> 
Sent: Saturday, December 24, 2011 4:35 AM
Subject: Re: [Spice-devel] VideoStream - MJpeg Encode/Decode.
On Fri, Dec 23, 2011 at 09:17:58AM -0800, Naga Mohan Pothula wrote:
>    Hi,
>    I have doubt on MJpeg encode/decode module. I've seen Frame rect with ODD
>    format is not accepting by MJpegDecoder at "convert_scanline" function.
>    ASSERT(_width % 2 == 0);
>    ASSERT(_height % 2 == 0);
>    Spice session crash happens due to this assertion.
>    Why the decoder accepts only EVEN format frames? If this is the case why
>    we are not going to restrict at MJpeg Encoder rather than keeping an
>    assertion at MJpeg Decoder. 
>    How we are dealing with ODD format Frame rects for MJpeg? 

IIRC we produce even width and height in the encoder, hence the
assertion. Take a look at the server side encoder.

>    Appreciated your help.
>    Mohan.

> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20111228/e564b13d/attachment.html>

More information about the Spice-devel mailing list