[Spice-devel] [PATCH spice-gtk 2/5] usb-device-manager: Make spice_usb_device_manager_connect_device async

Marc-André Lureau marcandre.lureau at gmail.com
Tue Nov 15 11:38:40 PST 2011


Hi,

The convention for gio async api is to have _async suffix. I think we
should follow it.

Please add the new functions in map-file.

You need the following change as well, to fix the VAPI bindings.

diff --git a/vapi/Makefile.am b/vapi/Makefile.amindex 87ffb8a..49f8509
100644--- a/vapi/Makefile.am+++ b/vapi/Makefile.am@@ -4,6 +4,7 @@ if
WITH_VALA vapidir = $(datadir)/vala/vapi vapi_DATA =
                         \        spice-client-glib-2.0.vapi
           \+       spice-client-glib-2.0.deps                      \
      spice-client-gtk-$(SPICE_GTK_API_VERSION).deps  \
spice-client-gtk-$(SPICE_GTK_API_VERSION).vapi  \        $(NULL)diff
--git a/vapi/spice-client-glib-2.0.deps
b/vapi/spice-client-glib-2.0.depsnew file mode 100644index
0000000..cd10dfd--- /dev/null+++ b/vapi/spice-client-glib-2.0.deps@@
-0,0 +1 @@+gio-2.0

-- 
Marc-André Lureau


More information about the Spice-devel mailing list