[Spice-devel] [PATCH spice-gtk 2/5] usb-device-manager: Make spice_usb_device_manager_connect_device async

Hans de Goede hdegoede at redhat.com
Tue Nov 15 12:57:48 PST 2011


Hi,

On 11/15/2011 08:38 PM, Marc-André Lureau wrote:
> Hi,
>
> The convention for gio async api is to have _async suffix. I think we
> should follow it.

I didn't do that because polkit-gobject does it the other way (_sync for
sync functions). But thinking more about it I agree with you, I'll do a
second version of this patchset and add the suffix.

> Please add the new functions in map-file.

Good one will fix as well.

>
> You need the following change as well, to fix the VAPI bindings.

Erm, I'm afraid the patch did not survive the mail chain. Can you resend
it attached?

Regards,

Hans


More information about the Spice-devel mailing list