[Spice-devel] [RFC PATCH spice 0.8 05/19] server, proto: tell the client to connect to the migration target before migraton starts

[Gerd Hoffmann]

   Hi,

> diff --git a/spice.proto b/spice.proto
> index 6160de1..d5b954e 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -167,9 +167,8 @@ channel MainChannel : BaseChannel {
>   	uint16 sport;
>   	uint32 host_size;
>   	uint8 *host_data[host_size] @zero_terminated @marshall @nonnull;
> -	pubkey_type pub_key_type;
> -	uint32 pub_key_size;
> -	uint8 *pub_key_data[pub_key_size] @zero_terminated  @marshall @nonnull;
> +	uint32 cert_subject_size;
> +	uint8 *cert_subject_data[cert_subject_size] @zero_terminated @marshall;
>       } @ctype(SpiceMsgMainMigrationBegin) migrate_begin = 101;

Is it safe to change the protocol like this?
[ I think it is as the message is unused, just asking to be sure ]

How about adding a "migration-type" or a "flags" field?  Then the 
message can be used to kick off both semi-seamless and real-seamless 
migration.

cheers,
   Gerd