[Spice-devel] [RFC PATCH spice 0.8 05/19] server, proto: tell the client to connect to the migration target before migraton starts

[Yonit Halperin]

On 09/19/2011 03:21 PM, Gerd Hoffmann wrote:
> Hi,
>
>> diff --git a/spice.proto b/spice.proto
>> index 6160de1..d5b954e 100644
>> --- a/spice.proto
>> +++ b/spice.proto
>> @@ -167,9 +167,8 @@ channel MainChannel : BaseChannel {
>> uint16 sport;
>> uint32 host_size;
>> uint8 *host_data[host_size] @zero_terminated @marshall @nonnull;
>> - pubkey_type pub_key_type;
>> - uint32 pub_key_size;
>> - uint8 *pub_key_data[pub_key_size] @zero_terminated @marshall @nonnull;
>> + uint32 cert_subject_size;
>> + uint8 *cert_subject_data[cert_subject_size] @zero_terminated @marshall;
>> } @ctype(SpiceMsgMainMigrationBegin) migrate_begin = 101;
>
> Is it safe to change the protocol like this?
> [ I think it is as the message is unused, just asking to be sure ]
It is used only in Rhel5 servers, and spice1.proto is unchanged.
>
> How about adding a "migration-type" or a "flags" field? Then the message
> can be used to kick off both semi-seamless and real-seamless migration.
Actually I don't think the public key field will ever be in use. It is 
not essential for seamless. Seamless will use the cert subject as well.
In rhel5 the target passed the public key to the src via the dedicated 
channel they had. From rhel6 we use the cert subject for authentication 
instead.
>
> cheers,
> Gerd
>