[Spice-devel] [PATCH v2 spice 01/11] server/red_worker: fix dump_bitmap

[Yonit Halperin]

On 04/17/2012 01:46 PM, Alon Levy wrote:
> On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
>> ---
>>   server/red_worker.c |    5 +++--
>>   1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/server/red_worker.c b/server/red_worker.c
>> index 07782c8..5350195 100644
>> --- a/server/red_worker.c
>> +++ b/server/red_worker.c
>> @@ -11348,10 +11348,11 @@ static void dump_bitmap(RedWorker *worker, SpiceBitmap *bitmap, uint32_t group_i
>>       }
>>       /* writing the data */
>>       for (i = 0; i<  bitmap->data->num_chunks; i++) {
>> +        int j;
>
> Missed this in v1, sorry - shouldn't this be defined at the function
> start? Not a big deal.
why?
>
>>           SpiceChunk *chunk =&bitmap->data->chunk[i];
>>           int num_lines = chunk->len / bitmap->stride;
>> -        for (i = 0; i<  num_lines; i++) {
>> -            dump_line(f, chunk->data + (i * bitmap->stride), n_pixel_bits, bitmap->x, row_size);
>> +        for (j = 0; j<  num_lines; j++) {
>> +            dump_line(f, chunk->data + (j * bitmap->stride), n_pixel_bits, bitmap->x, row_size);
>>           }
>>       }
>>       fclose(f);
>> --
>> 1.7.7.6
>>