[Spice-devel] [PATCH v2 spice 01/11] server/red_worker: fix dump_bitmap

[Christophe Fergeau]

On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
> On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
> > ---
> >  server/red_worker.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 07782c8..5350195 100644
> > --- a/server/red_worker.c
> > +++ b/server/red_worker.c
> > @@ -11348,10 +11348,11 @@ static void dump_bitmap(RedWorker *worker, SpiceBitmap *bitmap, uint32_t group_i
> >      }
> >      /* writing the data */
> >      for (i = 0; i < bitmap->data->num_chunks; i++) {
> > +        int j;
> 
> Missed this in v1, sorry - shouldn't this be defined at the function
> start? Not a big deal.

In my opinion, it's better to keep variable declaration in the smallest
enclosing block.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120417/425f6e50/attachment.pgp>