[Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

Marc-André Lureau marcandre.lureau at gmail.com
Thu Apr 19 16:59:05 PDT 2012


Hi

Now that I implemented it a bit more correctly, using a timer, and
splitting the in two patches, I realize that it doesn't work with
windows. Windows expect to receive several key press events
apparently. Hans, the hack you mentionned in spicec doesn't seem to be
what you said, since spicec client repeatly sends down messages when
the key is pressed (btw, Gtk doesn't behave the way you described
either, so this previous patch was working fine)

So it seems like we should keep sending repeat key press in fact. And
it's probably better to rely on client-side repeat, since letting the
server handling it may lead to precisely the bug I was trying to fix.
And we should teach the agent to disable the key repeat function,
which is a trival xset -r, or XGetKeyboardControl /
XChangeKeyboardControl equivalent when a client is connected. Any
other opinion?

-- 
Marc-André Lureau


More information about the Spice-devel mailing list