[Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

[Alon Levy]

On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote:
> Hi
> 
> Now that I implemented it a bit more correctly, using a timer, and
> splitting the in two patches, I realize that it doesn't work with
> windows. Windows expect to receive several key press events
> apparently. Hans, the hack you mentionned in spicec doesn't seem to be
> what you said, since spicec client repeatly sends down messages when
> the key is pressed (btw, Gtk doesn't behave the way you described
> either, so this previous patch was working fine)
> 
> So it seems like we should keep sending repeat key press in fact. And
> it's probably better to rely on client-side repeat, since letting the
> server handling it may lead to precisely the bug I was trying to fix.
> And we should teach the agent to disable the key repeat function,
> which is a trival xset -r, or XGetKeyboardControl /
> XChangeKeyboardControl equivalent when a client is connected. Any
> other opinion?

Using the agent to disable key repeat sounds fine, but you want to do
that for windows as well.

Just to be clear, you propose the client generates the repeat, and the
agent disable the guest repeat, so if there is jitter in the network the
repeated key press events as seen by the guest would have differing time
difference.

> 
> -- 
> Marc-André Lureau
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel