[Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

Christophe Fergeau cfergeau at redhat.com
Wed Aug 8 02:34:50 PDT 2012


On Wed, Aug 08, 2012 at 05:24:30AM -0400, Yaniv Kaul wrote:
> ----- Original Message -----
> > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote:
> > > From: Erlon Cruz <erlon.cruz at br.flextronics.com>
> > > 
> > > Signed-off-by: Erlon R. Cruz <erlon.cruz at br.flextronics.com>
> > > Signed-off-by: Fabiano Fidêncio
> > > <Fabiano.Fidêncio at fit-tecnologia.org.br>
> > > Signed-off-by: Rafael F. Santos
> > > <Rafael.Santos at fit-tecnologia.org.br>
> > > ---
> > >  server/glz_encoder.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/server/glz_encoder.c b/server/glz_encoder.c
> > > index 1ec1f9b..f8415a8 100644
> > > --- a/server/glz_encoder.c
> > > +++ b/server/glz_encoder.c
> > > @@ -261,7 +261,7 @@ int glz_encode(GlzEncoderContext
> > > *opaque_encoder,
> > >      encoder->cur_image.id = dict_image->id;
> > >      encoder->cur_image.first_win_seg = dict_image->first_seg;
> > >  
> > > -    encode_32(encoder, LZ_MAGIC);
> > > +    encode_32(encoder, htole32(LZ_MAGIC));
> 
> The correct thing to do here is drop LZ_MAGIC. No one needs it.
> And the version stuff that follows it as well. It's useless.

It's not useless to old clients as they won't be able to communicate with
the server if these fields are not there. I think some people would hate us
if we broke that ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120808/2b4ce3cd/attachment.pgp>


More information about the Spice-devel mailing list