[Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()

[Daniel P. Berrange]

On Fri, Feb 17, 2012 at 12:53:48PM +0100, Paolo Bonzini wrote:
> On 02/17/2012 10:05 AM, Alon Levy wrote:
> > The patch itself looks ok, but I'm not sure I like the direction. Why
> > not specialize, have epoll for linux and poll if epoll isn't supported?
> >  - double the code
> >  + no possible regression
> 
> - guaranteed bitrot in the poll() path :)

Or perhaps consider using something like libevent.so ? This has solved
this problem for all platforms, but it might be considered overkill ?

Regards,
Daniel.
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|