[Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()
Paolo Bonzini
pbonzini at redhat.com
Fri Feb 17 04:12:50 PST 2012
On 02/17/2012 12:59 PM, Daniel P. Berrange wrote:
>>> > > The patch itself looks ok, but I'm not sure I like the direction. Why
>>> > > not specialize, have epoll for linux and poll if epoll isn't supported?
>>> > > - double the code
>>> > > + no possible regression
>> >
>> > - guaranteed bitrot in the poll() path :)
> Or perhaps consider using something like libevent.so ? This has solved
> this problem for all platforms, but it might be considered overkill ?
So QEMU would have glib's event loop, its own, and also libevent's. I
like it :) but Dan's code is simple enough that going with poll() makes
sense.
Paolo
More information about the Spice-devel
mailing list