[Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()

[Alon Levy]

On Fri, Feb 17, 2012 at 12:53:48PM +0100, Paolo Bonzini wrote:
> On 02/17/2012 10:05 AM, Alon Levy wrote:
> > The patch itself looks ok, but I'm not sure I like the direction. Why
> > not specialize, have epoll for linux and poll if epoll isn't supported?
> >  - double the code
> >  + no possible regression
> 
> - guaranteed bitrot in the poll() path :)
> 

Yeah, I guess you are right. I'm worried since I don't know the
difference in performance between epoll and poll, and also the poll code
is a little more complex. I'd be glad to drop in libevent/glib, but it
seems wrong to ask Dan to do that when his patch looks fine (multiple
clients is a non issue).

Let's wait for someone else to chime in.

> Paolo
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel